[Spread-users] [PATCH] wrong dependency under libspread

[Simone Piunno]

Hello,

make install fails because for shared libs the install command gets
called before mkinstalldirs.
Please include the attached patch.

Thank you


-------------- next part --------------
Copyright (C) 2007 Simone Piunno

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
    
    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
    EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
    MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
    NONINFRINGEMENT. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE LIABLE FOR
    ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
    CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
    WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

On amd64 shared libs installation fails because it happens before mkinstalldirs

--- libspread/Makefile.in	2007-10-14 14:57:50.000000000 +0200
+++ libspread/Makefile.in	2007-10-14 15:04:33.000000000 +0200
@@ -123,7 +123,7 @@
 libspread-core.so:	$(LIBSP_SHOBJS)
 	$(SHLD) -o $@ $(LIBSP_SHOBJS) $(SHLDFLAGS) $(SHLIBS)
 
-install-libspread-core.so:	libspread-core.so
+install-libspread-core.so:	libspread-core.so mkinstalldirs
 	$(INSTALL) -m 0755 libspread-core.so $(DESTDIR)$(libdir)/libspread-core.so.$(LIBVERSION)
 	(cd $(DESTDIR)$(libdir); $(SOFTLINK) -f libspread-core.so.$(LIBVERSION) libspread-core.so)
 
@@ -142,7 +142,7 @@
 libtspread-core.so:	$(LIBTSP_SHOBJS)
 	$(SHLD) -o $@ $(LIBTSP_SHOBJS) $(SHLDFLAGS) $(SHLIBS) $(THLIBS)
 
-install-libtspread-core.so:	libtspread-core.so
+install-libtspread-core.so:	libtspread-core.so mkinstalldirs
 	$(INSTALL) -m 0755 libtspread-core.so $(DESTDIR)$(libdir)/libtspread-core.so.$(LIBVERSION)
 	(cd $(DESTDIR)$(libdir); $(SOFTLINK) -f libtspread-core.so.$(LIBVERSION) libtspread-core.so)
 
@@ -164,7 +164,7 @@
 libspread.so:	$(LIBTFL_SHOBJS)
 	$(SHLD) -o $@ $(LIBTFL_SHOBJS) $(SHLDFLAGS) $(SHARED_STDUTIL) $(SHLIBS) $(THLIBS)
 
-install-libspread.so:	libspread.so
+install-libspread.so:	libspread.so mkinstalldirs
 	$(INSTALL) -m 0755 libspread.so $(DESTDIR)$(libdir)/libspread.so.$(LIBVERSION)
 	(cd $(DESTDIR)$(libdir); $(SOFTLINK) -f libspread.so.$(LIBVERSION) libspread.so)
 
@@ -195,9 +195,11 @@
 
 install: $(TARGETS) install-files install- at LIBSPSO@ install- at LIBSPCORESO@ install- at LIBTSPCORESO@
 
-install-files:
+mkinstalldirs:
 	$(buildtoolsdir)/mkinstalldirs $(DESTDIR)$(libdir)
 	$(buildtoolsdir)/mkinstalldirs $(DESTDIR)$(includedir)
+
+install-files: mkinstalldirs
 	$(INSTALL) -m 644 libspread.a $(DESTDIR)$(libdir)/libspread.a
 	$(INSTALL) -m 644 libspread-core.a $(DESTDIR)$(libdir)/libspread-core.a
 	$(INSTALL) -m 644 libtspread-core.a $(DESTDIR)$(libdir)/libtspread-core.a